convert AssetKey to StrictModel #20643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branch-name: strict-model
branch-name: asset-key-strict-model
sryza
force-pushed
the
asset-key-strict-model
branch
from
313f29b to
ead649f
Compare
|
given the very large volume of these objects we end up with, I think it would be good to do some quick bench marking to prove to ourselves that moving from tuple to model isn't a meaningful difference in memory / cpu |
sryza
added a commit
that referenced
this pull request
Mar 25, 2024
## Summary & Motivation Introduces a `StrictModel` class, which is a subclass of `pydantic.BaseModel` that's frozen and doesn't allow default constructor arguments that aren't class members. The idea is for this to eventually replace all our uses of `NamedTuple`, `BaseModel`, and `@dataclass`. This is a replacement for the unmerged #20461. Downstream PRs that demonstrate its usage: - #20641 - #20643 - #20638 ## How I Tested These Changes
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation Introduces a `StrictModel` class, which is a subclass of `pydantic.BaseModel` that's frozen and doesn't allow default constructor arguments that aren't class members. The idea is for this to eventually replace all our uses of `NamedTuple`, `BaseModel`, and `@dataclass`. This is a replacement for the unmerged #20461. Downstream PRs that demonstrate its usage: - #20641 - #20643 - #20638 ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes